trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nonstop-qfchen <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: fix 1795: findPort.py may find s...
Date Mon, 01 Feb 2016 00:42:01 GMT
GitHub user nonstop-qfchen opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/297

    fix 1795: findPort.py may find some ports that are in CLOSE_WAIT state

    Hi,
    
    Could you please do a quick review of the fix to findPort.py?  In the fix, a new method
to find the port numbers in use is added. This method utilizes the command "sudo lsof -i"
and then do a simple parsing to grab all these port numbers. If the sudo command is unable
to run, then the existing method is called. 
    
    Thanks --Qifan

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nonstop-qfchen/incubator-trafodion findport_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #297
    
----
commit 57a5527f31fe36b708cb49cca00e25d89fbe762d
Author: Qifan Chen <qfc@adev04.esgyn.com>
Date:   2016-02-01T00:36:12Z

    fix 1795: findPort.py may find some ports that are in CLOSE_WAIT state

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message