trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From svarnau <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1733][TRAFODION-1734]...
Date Thu, 04 Feb 2016 22:34:51 GMT
GitHub user svarnau opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/307

    [TRAFODION-1733][TRAFODION-1734] License text improvements

    These changes are due to review feedback received from release 1.3.
    
        [TRAFODION-1734] License info improvements from reviews of 1.3 release
    
        Added info on particular type of BSD & MIT licenses used.
        Removed .txt file suffixes.
        Made copy of license rather than give URL.
        Removed license for protobuf, since we merely use the tool rather than
        include their software.
    
        [TRAFODION-1733] Remove unneeded info from license file
    
        The FBstring.h file is Apache license, not a different license, so
        no need to call it out.
    
        ASCIIdoc is a tool that is used to generate files in build process
        but the software is not distributed with Traodion software, so it
        does not apply.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/svarnau/incubator-trafodion lic

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #307
    
----
commit 36ca93cbd3348637c571065a6093acf09c74fe31
Author: Steve Varnau <steve.varnau@esgyn.com>
Date:   2016-02-04T18:35:45Z

    [TRAFODION-1733] Remove unneeded info from license file
    
    The FBstring.h file is Apache license, not a different license, so
    no need to call it out.
    
    ASCIIdoc is a tool that is used to generate files in build process
    but the software is not distributed with Traodion software, so it
    does not apply.

commit 8ea14f38714cad303651d32c97c2c91576a4fcbd
Author: Steve Varnau <steve.varnau@esgyn.com>
Date:   2016-02-04T22:25:16Z

    [TRAFODION-1734] License info improvements from reviews of 1.3 release
    
    Added info on particular type of BSD & MIT licenses used.
    Removed .txt file suffixes.
    Made copy of license rather than give URL.
    Removed license for protobuf, since we merely use the tool rather than
    include their software.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message