trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Fixes for TRAFODION-1789 & TRAFO...
Date Fri, 12 Feb 2016 16:06:17 GMT
GitHub user robertamarton opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/319

    Fixes for TRAFODION-1789 & TRAFODION-1812

    TRAFODION-1789: Create the histogram metadata tables at schema creation time
    TRAFODION-1812: cleanup schema causes transaction to hang in aborting state

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertamarton/incubator-trafodion schema-changes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #319
    
----
commit a22f6853e07ebc917340dc08d2582f8147bae2b1
Author: Roberta Marton <roberta.marton@apache.org>
Date:   2016-02-12T16:00:47Z

    TRAFODION-1789 & TRAFODION-1812
    
    TRAFODION-1789: Create the histogram metadata tables at schema creation time
    
    Added a list of MDTableInfo structs called allMDHistInfo that describes
    histogram tables similar to other metadata tables in CmpSeabaseDDLmd.h.
    During schema create, this list is traversed and each histogram table created.
    This is performed by calling the static function - createHistogramTables.
    Similarily, this list is traversed at drop schema time to drop existing
    histogram tables.  With this change, you can drop a schema without the
    cascade option when only histogram tables remain.
    
    In histogram code (hs_cli.cpp), removed hard coded create statements and
    changed code to call the createHistogramTables static function.  With this
    change, there is only one place where Histogram tables are defined.  Today,
    histogram tables are defined in ../sqlcomp/CmpSeabaseDDLmd.h and
    ../ustat/hs_cli.cpp
    
    TRAFODION-1812: cleanup schema causes transaction to hang in aborting state
    
    While testing the fix for TRAFODION-1789, some of the regression tests failed.
    There is an issue when trying to cleanup a schema that contains histogram
    tables. Changes were made to cleanup histogram tables first and to avoid
    deleting histogram entries for the histogram table itself.
    
    Added IF EXISTS syntax to routine drops. Also added IF NOT EXISTS syntax to
    routine creates. The DROP IF EXISTS was needed to fix an issue when dropping
    routines as part of drop schema code.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message