From codereview-return-1550-apmail-trafodion-codereview-archive=trafodion.apache.org@trafodion.incubator.apache.org Mon Feb 1 16:59:22 2016 Return-Path: X-Original-To: apmail-trafodion-codereview-archive@minotaur.apache.org Delivered-To: apmail-trafodion-codereview-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 733C618BCE for ; Mon, 1 Feb 2016 16:59:22 +0000 (UTC) Received: (qmail 45630 invoked by uid 500); 1 Feb 2016 16:59:19 -0000 Delivered-To: apmail-trafodion-codereview-archive@trafodion.apache.org Received: (qmail 45597 invoked by uid 500); 1 Feb 2016 16:59:19 -0000 Mailing-List: contact codereview-help@trafodion.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: codereview@trafodion.incubator.apache.org Delivered-To: mailing list codereview@trafodion.incubator.apache.org Received: (qmail 45582 invoked by uid 99); 1 Feb 2016 16:59:19 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Feb 2016 16:59:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B522B18048C for ; Mon, 1 Feb 2016 16:59:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.427 X-Spam-Level: X-Spam-Status: No, score=0.427 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id iEzeqJqexe_Q for ; Mon, 1 Feb 2016 16:59:10 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 4C73631ADE for ; Mon, 1 Feb 2016 16:59:09 +0000 (UTC) Received: (qmail 45511 invoked by uid 99); 1 Feb 2016 16:59:08 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Feb 2016 16:59:08 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 51D40DFCDD; Mon, 1 Feb 2016 16:59:08 +0000 (UTC) From: DaveBirdsall To: codereview@trafodion.incubator.apache.org Reply-To: codereview@trafodion.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-trafodion pull request: Additional changes for JIRA [TRA... Content-Type: text/plain Message-Id: <20160201165908.51D40DFCDD@git1-us-west.apache.org> Date: Mon, 1 Feb 2016 16:59:08 +0000 (UTC) Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/296#discussion_r51445704 --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/coprocessor/transactional/generated/TrxRegionProtos.java --- @@ -26558,6 +26558,16 @@ public Builder clearHasException() { * required int64 auditSeqNum = 4; */ long getAuditSeqNum(); + + // required bool ageCommitted = 5; + /** + * required bool ageCommitted = 5; + */ + boolean hasAgeCommitted(); + /** + * required bool ageCommitted = 5; --- End diff -- What is the point of the repeated required bool ageCommitted = 5; comments? There seems to be several of them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---