trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1686][MTDCS] ODBC: SQ...
Date Wed, 13 Apr 2016 15:35:58 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/430#discussion_r59570974
  
    --- Diff: core/conn/jdbc_type2/native/SqlInterface.cpp ---
    @@ -246,10 +246,14 @@ SQLRETURN GetJDBCValues( SQLItemDesc_def *SQLItemDesc,
     		SQLItemDesc->signType      = TRUE;
     		break;
     	case SQLTYPECODE_DATETIME:
    +		// Calculate the length based on YYYY/MM/DD HH:MM:SS.ffffff
    +        SQLItemDesc->maxLen = 20 + 6;
     		switch (SQLItemDesc->datetimeCode)
     		{
     		case SQLDTCODE_DATE:
     			SQLItemDesc->ODBCDataType = SQL_TYPE_DATE;
    +            // For DATE, update the maxLen since it only have YYYY/MM/DD
    +            SQLItemDesc->maxLen = 10;
     			break;
     		case SQLDTCODE_TIME:
     			SQLItemDesc->ODBCDataType = SQL_TYPE_TIME;
    --- End diff --
    
    Should we add code to calculate maxLen for TIME as well? (It would be just HH:MM:SS)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message