trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Fix for JIRA [TRAFODION-1935]
Date Fri, 15 Apr 2016 21:22:08 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/436#discussion_r59942949
  
    --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/transactional/TransactionManager.java
---
    @@ -549,13 +549,15 @@ public SsccCommitResponse call(SsccRegionService instance) throws
IOException {
                    retry = false;
                  }
               }
    -          catch (UnknownTransactionException ute) {
    -              LOG.error("Got unknown exception in doCommitX by participant " + participantNum
    -            		  + " for transaction: " + transactionId + " " + ute);
    -              transactionState.requestPendingCountDec(true);
    -              throw new UnknownTransactionException();
    -          }
               catch (Exception e) {
    +             if(e.toString().contains("UnknownTransactionException")) {
    --- End diff --
    
    Is it conceivable that we might get a false positive with a string lookup? (Could the
characters "UnknownTransactionException" occur for some other reason in the text, for example
as part of a delimited identifier for a Trafodion table name?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message