trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1421] Implement paral...
Date Fri, 15 Apr 2016 21:36:46 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/422#discussion_r59944770
  
    --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/ClientScanner98.java.tmpl
---
    @@ -0,0 +1,490 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.hadoop.hbase.client;
    +
    +import java.io.IOException;
    +import java.util.LinkedList;
    +
    +import org.apache.commons.logging.Log;
    +import org.apache.commons.logging.LogFactory;
    +import org.apache.hadoop.classification.InterfaceAudience;
    +import org.apache.hadoop.classification.InterfaceStability;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hbase.Cell;
    +import org.apache.hadoop.hbase.DoNotRetryIOException;
    +import org.apache.hadoop.hbase.HBaseConfiguration;
    +import org.apache.hadoop.hbase.HConstants;
    +import org.apache.hadoop.hbase.HRegionInfo;
    +import org.apache.hadoop.hbase.KeyValueUtil;
    +import org.apache.hadoop.hbase.NotServingRegionException;
    +import org.apache.hadoop.hbase.TableName;
    +import org.apache.hadoop.hbase.UnknownScannerException;
    +import org.apache.hadoop.hbase.exceptions.OutOfOrderScannerNextException;
    +import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
    +import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
    +import org.apache.hadoop.hbase.protobuf.generated.MapReduceProtos;
    +import org.apache.hadoop.hbase.regionserver.RegionServerStoppedException;
    +import org.apache.hadoop.hbase.util.Bytes;
    +
    +/**
    + * Implements the scanner interface for the HBase client.
    + * If there are multiple regions in a table, this scanner will iterate
    + * through them all.
    + */
    +@InterfaceAudience.Public
    +@InterfaceStability.Stable
    +public class ClientScanner98 extends AbstractClientScanner {
    +    private final Log LOG = LogFactory.getLog(this.getClass());
    +    protected Scan scan;
    +    protected boolean closed = false;
    +    // Current region scanner is against.  Gets cleared if current region goes
    +    // wonky: e.g. if it splits on us.
    +    protected HRegionInfo currentRegion = null;
    +    protected ScannerCallable callable = null;
    +    protected final LinkedList<Result> cache = new LinkedList<Result>();
    +    protected final int caching;
    +    protected long lastNext;
    +    // Keep lastResult returned successfully in case we have to reset scanner.
    +    protected Result lastResult = null;
    --- End diff --
    
    Should the close method reset lastResult to null to aid in garbage collection?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message