trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: TRAFODION-1940 better NATable st...
Date Tue, 19 Apr 2016 23:15:45 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/442#discussion_r60328470
  
    --- Diff: core/sql/regress/hive/TEST009 ---
    @@ -170,7 +170,7 @@ sh sqlci -i "TEST009(select_stmts)";
     select catalog_name, schema_name, object_name from table(natablecacheentries('user','local'))
order by 1,2,3;
     drop external table t009t1 for hive.sch_t009.t009t1;
     get tables in schema "_HV_SCH_T009_";
    -select * from table(natablecacheentries('user','local')) order by 2,3,4;
    +select row_id, catalog_name, schema_name, object_name from table(natablecacheentries('user','local'))
order by 2,3,4;
    --- End diff --
    
    Looks good. I'm wondering if it would  be useful to add a test that also shows the new
context column?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message