trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amandamoran <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Vanilla Apache HBase support and...
Date Wed, 20 Apr 2016 17:54:33 GMT
Github user amandamoran commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/440#discussion_r60456457
  
    --- Diff: install/installer/traf_config_check ---
    @@ -595,10 +598,40 @@ else
     fi
     }
     
    +function setPath {
    +
    +export PATH=$PATH:$HADOOP_PREFIX/bin:$HADOOP_PREFIX/sbin:$HBASE_HOME/bin
    +
    +sudo chmod 777 $TRAF_CONFIG
    +sed -i '/PATH\=/d' $TRAF_CONFIG
    +echo "export PATH=\"$PATH\"" >> $TRAF_CONFIG
    +sudo chmod 777 $TRAF_CONFIG
    +source $TRAF_CONFIG
    +
    +}
    +
    +function setHBaseDistro {
    +
    +export HBASE_DISTRO="APACHE" 
    +
    --- End diff --
    
    I agree. This variable is only used with Hadoop version is Apache in sqenvcom.sh. 
    
    A JIRA to improve sqnencom.sh to be more standard and use more of the current variables
would be a good idea. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message