trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Various fixes (details below)
Date Mon, 25 Apr 2016 23:44:28 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/444#discussion_r61009125
  
    --- Diff: core/sql/executor/ExExeUtilVolTab.cpp ---
    @@ -537,15 +539,23 @@ short ExExeUtilCleanupVolatileTablesTcb::work()
     	    char * schemaName = vi->get(0);
     	    retcode =
     	      dropVolatileSchema(masterGlob->getStatement()->getContext(),
    -				 schemaName, getHeap(), getGlobals());
    +				 schemaName, getHeap(), getGlobals(),
    +                                 getDiagsArea());
     	    if (retcode < 0)
     	      {
    +                // changes errors to warnings and move on to next schema.
    +                if (getDiagsArea())
    +                  getDiagsArea()->negateAllErrors();
    +
     		// clear diags and move on to next schema.
     		// Remember that an error was returned, we will
     		// return a warning at the end.
     		SQL_EXEC_ClearDiagnostics(NULL);
     		retcode = 0;
     
    +                if ((strlen(errorSchemas_) + strlen(schemaName)) < 1000)
    +                  strcat(errorSchemas_, schemaName);
    --- End diff --
    
    Do you want to stick any delimiter (say a comma or a space) between schema names? Maybe
that is already present in schemaName? Also, if they don't all fit, do you want to put some
indicator (such as "...") at the end?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message