trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Various fixes (details below)
Date Tue, 26 Apr 2016 15:54:40 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/444#discussion_r61112170
  
    --- Diff: core/sql/executor/ExExeUtilVolTab.cpp ---
    @@ -554,7 +554,12 @@ short ExExeUtilCleanupVolatileTablesTcb::work()
     		retcode = 0;
     
                     if ((strlen(errorSchemas_) + strlen(schemaName)) < 1000)
    -                  strcat(errorSchemas_, schemaName);
    +                  {
    +                    strcat(errorSchemas_, schemaName);
    +                    strcat(errorSchemas_, " ");
    +                  }
    +                else
    +                  strcat(errorSchemas_, "..."); // could not fit
    --- End diff --
    
    We would want to do this at most once. As written we could keep appending dots and have
a buffer overflow. (Apologies; I know this change was in response to one of my earlier comments.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message