trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1955] JNI optimizatio...
Date Sat, 30 Apr 2016 00:10:00 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/459#discussion_r61659862
  
    --- Diff: core/sql/executor/HBaseClient_JNI.cpp ---
    @@ -5619,3 +5394,41 @@ int convertStringObjectArrayToList(NAHeap *heap, jarray j_objArray,
         return arrayLen;
     }
     
    +
    +jint convertByteArrayObjectArrayToNAArray(NAHeap *heap, jarray j_objArray, NAArray<HbaseStr>
**retArray)
    +{
    --- End diff --
    
    For safety, might be a good idea to set retArray = 0 first thing in the method. Otherwise
a caller might ignore an error and use the uninitialized pointer, with unpredictable results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message