trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1920] suppress SQL er...
Date Wed, 04 May 2016 13:59:55 GMT
Github user anoopsharma00 commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/461#discussion_r62043077
  
    --- Diff: core/sql/generator/GenRelScan.cpp ---
    @@ -880,6 +884,12 @@ short FileScan::codeGenForHive(Generator * generator)
       } // for (ii = 0; ii < hdfsVals; ii++)
         
     
    +  UInt32 hiveScanMode = CmpCommon::getDefaultLong(HIVE_SCAN_SPECIAL_MODE);
    +  //enhance pCode to handle this mode in the future
    +  //this is for JIRA 1920
    +  if((hiveScanMode & 2 ) > 0)   //if HIVE_SCAN_SPECIAL_MODE is 2, disable pCode
    +    exp_gen->setPCodeMode(ex_expr::PCODE_NONE);
    +
    --- End diff --
    
    This will disable pcode for the whole expression and all conversions.
    Better place to disable it is in ex_conv_clause::pcodeGenererate in
    file exp/ExpPCodeClauseGen.cpp.
    That code should check for conv_to_null_when_error flag in ex_conv_clause
    and disable pcode just for that clause.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message