trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From blfritch-esgyn <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-1971] Avoid redundant...
Date Fri, 13 May 2016 21:06:55 GMT
Github user blfritch-esgyn commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/480#discussion_r63251179
  
    --- Diff: core/sql/executor/ExHbaseIUD.cpp ---
    @@ -1285,7 +1285,6 @@ ExWorkProcRetcode ExHbaseAccessBulkLoadPrepSQTcb::work()
           matches_ = 0;
           currRowNum_ = 0;
           numRetries_ = 0;
    -      hFileParamsInitialized_ = FALSE;
    --- End diff --
    
    samplingRate will be >0 only if the syntax to do it is used. Yes, the flush refers
to our own buffers. The HFile flushing is separate. I removed the comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message