trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [Trafodion 762] support HIVE dat...
Date Tue, 24 May 2016 15:51:21 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/496#discussion_r64419224
  
    --- Diff: core/sql/executor/ExExeUtilGet.cpp ---
    @@ -5171,14 +5212,24 @@ short ExExeUtilHiveMDaccessTcb::work()
     	    str_pad(infoCol->dtQualifier, 28, ' ');
     
     	    if (infoCol->fsDatatype == REC_DATETIME)
    -	      {
    +	    {
    +              if(infoCol->colSize > 10) {
     		// hive currently only supports timestamp
    --- End diff --
    
    Do we want to remove this comment since we support DATE now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message