trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-762] support HIVE dat...
Date Thu, 26 May 2016 01:08:27 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/496#discussion_r64678428
  
    --- Diff: core/sql/optimizer/NATable.cpp ---
    @@ -3553,6 +3553,48 @@ NAType* getSQColTypeForHive(const char* hiveType, NAMemory* heap)
       if ( !strcmp(hiveType, "timestamp"))
         return new (heap) SQLTimestamp(TRUE /* allow NULL */ , 6, heap);
     
    +  if ( !strcmp(hiveType, "date"))
    +    return new (heap) SQLDate(TRUE /* allow NULL */ , heap);
    +
    +  if ( !strncmp(hiveType, "varchar", 7) )
    +  {
    +    char maxLen[32];
    +    memset(maxLen, 0, 32);
    +    int i=0,j=0;
    +    int copyit = 0;
    +
    +    //get length
    +    for(i = 0; i < strlen(hiveType) ; i++)
    +    {
    +      if(hiveType[i] == '(') //start
    +      {
    +        copyit=1;
    +        continue;
    +      }
    +      else if(hiveType[i] == ')') //stop
    +        break; 
    +      if(copyit > 0)
    +      {
    +        maxLen[j] = hiveType[i];
    +        j++;
    +      }
    +    }
    +    Int32 len = atoi(maxLen);
    +
    +    if(len == 0) return NULL;  //cannot parse correctly
    +
    +    NAString hiveCharset =
    +        ActiveSchemaDB()->getDefaults().getValue(HIVE_DEFAULT_CHARSET);
    +
    +    return new (heap) SQLVarChar(CharLenInfo((hiveCharset == CharInfo::UTF8 ? 0 : len),len),
    --- End diff --
    
    @zellerh, your suggestion sounds good to me. To make it a bit more clear we could change
the name of the CQD to HIVE_MAX_STRING_LENGTH_IN_BYTES.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message