trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-2017] Use a maximum H...
Date Fri, 27 May 2016 15:33:55 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/505#discussion_r64923467
  
    --- Diff: core/sql/ustat/hs_globals.cpp ---
    @@ -546,10 +557,13 @@ NABoolean HSGlobalsClass::setHBaseCacheSize(double sampleRatio)
       Int64 workableCacheSize = (Int64)(sampleRatio * calibrationFactor);
       if (workableCacheSize < 1)
         workableCacheSize = 1;  // can't go below 1 unfortunately
    +  else if (workableCacheSize > 50)
    +    workableCacheSize = 50; 
     
    -  Int32 max = getDefaultAsLong(HBASE_NUM_CACHE_ROWS_MAX);
    -  if ((workableCacheSize < 10000) && // don't bother if 10000 works
    -      (max == 10000))  // don't do it if user has already set this CQD
    +  // if the user himself set the CQD, don't do anything
    +  NADefaults &defs = ActiveSchemaDB()->getDefaults();
    +  if (defs.getProvenance(HBASE_NUM_CACHE_ROWS_MAX) == 
    +      NADefaults::INIT_DEFAULT_DEFAULTS)
    --- End diff --
    
    Thanks, @selvaganesang. Will change in the next rework.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message