trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: Hive null values are now handled...
Date Fri, 27 May 2016 22:05:36 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/506#discussion_r64972368
  
    --- Diff: core/sql/regress/tools/runregr_hive.ksh ---
    @@ -225,43 +225,8 @@ skippedfiles=
     testfiles="$prettyfiles"
     prettyfiles=
     
    -# skip these tests on all platforms.
    -skipTheseTests=""
    -
    -# skip these tests for SQLMX and SQLMP tables on NSK platform
    -if [ $nsk -eq 1 ]; then
    -  skipTheseTests="TEST*"
    -fi
    -
    -# skip these tests for RELEASE ONLY tests on NSK
    -#if [ "$BUILD_FLAVOR" = "RELEASE" ]; then
    -#  skipTheseTests="$skipTheseTests TESTxxx"
    -#fi
    -
    -# skip these tests for DEBUG ONLY tests on NSK
    -#if [ "$BUILD_FLAVOR" = "DEBUG" ]; then
    -#  skipTheseTests="$skipTheseTests TESTxxx"
    -#fi
    -
    -# skip these tests for NT
    -if [ `uname` = "Windows_NT" ]; then
    -  skipTheseTests="TEST*"
    -fi
    -
    -
    -#skip these tests for Linux
    -#if [ `uname` = "Linux" ]; then
    -#  skipTheseTests="$skipTheseTests TESTxxx"
    -#fi
    -
    -#skip these tests when seabase eq 1.
    -if [ "$seabase" -ne 0 ]; then
    -  if [ "$seabase" -eq 1 ]; then
    -    skipTheseTests="TEST004"
    -  fi
    -fi
    -#skipTheseTests="TEST020"
    -skipTheseTests=
    +# skip these tests
    +skipTheseTests="TEST020"
    --- End diff --
    
    Did you intend to skip TEST020? It is not skipped now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message