trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: External lob support [TRAFODION-...
Date Fri, 27 May 2016 22:16:57 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/507#discussion_r64973294
  
    --- Diff: core/sql/comexe/ComTdbExeUtil.h ---
    @@ -2845,35 +2846,36 @@ class ComTdbExeUtilLobShowddl : public ComTdbExeUtil
     
       short getLOBnum(short i);
       char * getLOBloc(short i);
    -
    +  NABoolean getIsExternalLobCol(short i);
       UInt16 numLOBs() { return numLOBs_; }
     
       char * getLOBnumArray() { return lobNumArray_; }
       char * getLOBlocArray() { return lobLocArray_; }
    -
    +  char * getLOBtypeArray() { return lobTypeArray_;}
    + 
       char * schName() { return schName_; };
     private:
    -  UInt32 flags_;                                     // 00-03
    +  UInt32 flags_;                                    
     
    -  UInt16 numLOBs_;                                   // 04-05
    +  UInt16 numLOBs_;                                  
       short maxLocLen_;
       
       // array of shorts. numLOBs entries. 
       // Each entry is the lobNum.
    -  NABasicPtr lobNumArray_;                           // 08-15
    +  NABasicPtr lobNumArray_;                           
     
       // array of string, null terminated. numLOBs entries. 
       // Each entry is the storage location of lob data file.
    -  NABasicPtr lobLocArray_;                           // 16-23
    -
    -  Int64 objectUID_;                                  // 24-31
    +  NABasicPtr lobLocArray_;                          
    +  //array of int32. numLOBs entries
    +  NABasicPtr lobTypeArray_; 
    +  Int64 objectUID_;                                  
     
    -  NABasicPtr schName_;                               // 32-39
    -  short schNameLen_;                                 // 40-41
    +  NABasicPtr schName_;                               
    +  short schNameLen_;                                
     
    -  short sdOptions_;                                  // 42-43
    -
    -  char fillersComTdbExeUtilLobShowddl_[4];           // 44-47
    --- End diff --
    
    I guess we don't have to count bytes in TDBs anymore since all SQL is dynamic now. :-)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message