trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: JIRA TRAFODION-2006 Hive table structure a...
Date Tue, 31 May 2016 18:46:06 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/511#discussion_r65240592
  
    --- Diff: core/sql/optimizer/NATable.cpp ---
    @@ -7308,6 +7308,16 @@ NATable * NATableDB::get(const ExtendedQualName* key, BindWA* bindWA,
NABoolean
          }
       }
     
    +  // the reload cqd will be set during aqr after compiletime and runtime
    +  // timestamp mismatch is detected.
    +  // If set, reload hive metadata.
    +  if ((cachedNATable->isHiveTable()) &&
    +      (CmpCommon::getDefault(HIVE_DATA_MOD_CHECK) == DF_ON) &&
    +      (CmpCommon::getDefault(TRAF_RELOAD_NATABLE_CACHE) == DF_ON))
    --- End diff --
    
    Will this cause a reload *all* NATable information? It's too bad we don't have some way
to limit the reload to just the tables that have a metadata mismatch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message