trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-2009] fix parallel scanner issu...
Date Tue, 31 May 2016 20:47:58 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/
    @@ -116,21 +116,22 @@ public class TrafParallelClientScanner extends AbstractClientScanner
         LOG.debug("Found "+locs.size()+" region(s).");
         if (locs.size() == 0) return;
    +    int threads = parallelScaling>1.0 ?(int)Math.ceil(parallelScaling) : (int)Math.ceil(locs.size()
* parallelScaling);
    --- End diff --
    Not sure I understand the logic behind this. Suppose locs.size() is 3. If parallelScaling
is 1.1, then threads gets 2. If parallelScaling is 1.0, then threads gets 3. Seems odd that
parallelScaling getting smaller should result in more threads.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message