trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: JIRA TRAFODION-2006 Hive table structure a...
Date Tue, 31 May 2016 22:48:55 GMT
Github user anoopsharma00 commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/511#discussion_r65276706
  
    --- Diff: core/sql/executor/ExHdfsScan.cpp ---
    @@ -410,16 +411,81 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
     
     	    hdfsScanBufMaxSize_ = hdfsScanTdb().hdfsBufSize_;
     
    +            dataModCheckDone_ = FALSE;
    +
     	    if (numRanges_ > 0)
    -              step_ = INIT_HDFS_CURSOR;
    +              step_ = CHECK_FOR_DATA_MOD;
                 else
    -              step_ = DONE;
    +              step_ = CHECK_FOR_DATA_MOD_AND_DONE;
     	  }
     	  break;
     
    +        case CHECK_FOR_DATA_MOD:
    +        case CHECK_FOR_DATA_MOD_AND_DONE:
    +          {
    +            char * dirPath = hdfsScanTdb().hdfsRootDir_;
    --- End diff --
    
    At this time, data modification check for partitioned tables is not being
    supported. Once we support partitioned tables, we will need to enhance
    code to handle them.
    
    Here is the code in GenRelScan.cpp disabling it:
    
      // partitioned files. Skip data mod check for them.
     +      if (numOfPartLevels > 0)
     +        hdfsRootDir = NULL;



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message