trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request: [TRAFODION-2004][TRAFODION-1775] Two follo...
Date Tue, 31 May 2016 17:48:02 GMT
GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/509

    [TRAFODION-2004][TRAFODION-1775] Two follow-on fixes

    [TRAFODION-2004] In the review for https://github.com/apache/incubator-trafodion/pull/499,
@zellerh suggested adding an assert when CQD HOLDs overflow their stack. This has now been
done.
    [TRAFODION-1775] Pull request https://github.com/apache/incubator-trafodion/pull/292 (released
in release 2.0) added a new CQD, USTAT_YOULL_LIKELY_BE_SORRY. Unfortunately it was added as
a 32-bit integer, which meant that if one wanted to set it to 10 billion, then that would
fail with a validation error. But 10 billion is a reasonable size for a table. This code change
changes the validation rule to be a float greater than or equal to 1. So now 10 billion would
be possible.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion2004x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #509
    
----
commit 47c5bd95ca3595476957dbe86586f748c94dca67
Author: Dave Birdsall <dbirdsall@apache.org>
Date:   2016-05-31T17:42:45Z

    [TRAFODION-2004][TRAFODION-1775] Two follow-on fixes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message