trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kevinxu021 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #508: [TRAFODION-2018]T4 catalog (getProc...
Date Thu, 02 Jun 2016 03:29:17 GMT
Github user kevinxu021 commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/508#discussion_r65479759
  
    --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/T4DatabaseMetaData.java
---
    @@ -3092,27 +3090,40 @@ public boolean dataDefinitionIgnoredInTransactions() throws SQLException
{
     			// dropped from the search."
     			procedureNamePattern = "%";
     
    +		}else{
    +			procedureNamePattern = sqlValueFormat(procedureNamePattern);
    +		}
    +		MetadataHolder mdHolder = this.connection_.mdHolder_;
    +		int retryCnt = 0;
    +		while(retryCnt < 3 ) {
    +			try {
    +				PreparedStatement ps = mdHolder.getPStatement(SQL_API_SQLPROCEDURES, this.connection_);
    +				ps.setObject(1, schemaPattern);
    +				ps.setObject(2, procedureNamePattern);
    +				return ps.executeQuery();
    +			} catch (SQLException e) {
    +				mdHolder.removePStatement(SQL_API_SQLPROCEDURES);
    +				++retryCnt;
    +				if( retryCnt >= 3 ) {
    +					throw e;
    +				}
    +			}
     		}
    -		getSQLCatalogsInfo(connection_.getServerHandle(), // Server Handle
    -				SQL_API_SQLPROCEDURES, // catalogAPI
    -				catalogNm, // catalog
    -				schemaNm, // schema
    -				procedureNamePattern, // table name
    -				"", // tableTypeList
    -				"", // cloumn name
    -				(int) 0, // cloumnType
    -				(int) 0, // rowIdScope
    -				(long) 0, // nullable
    -				(int) 0, // uniqueness
    -				(int) 0, // accuracy
    -				(short) 0, // sqlType
    -				(int) 0, // metadataId
    -				"", // fcatalog
    -				"", // fschema
    -				"" // ftable
    -		);
    +		return null;
    +	}
    --- End diff --
    
    Thanks for comments. i'm not sure what you meant. Hundreds of clients with have hundreds
connection, in current implementation, it will create a statement for each connection.(ref:
https://github.com/apache/incubator-trafodion/blob/master/core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp)
And it has nothing different between implement on driver-side and server-side. By the way,
if you want to make them different on server-side, you have to make a new API for each other.
please review source code from srvrothers.cpp for more details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message