trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #496: [TRAFODION-762] support HIVE data typ...
Date Fri, 03 Jun 2016 02:21:05 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/496#discussion_r65648854
  
    --- Diff: core/sql/executor/ExExeUtilGet.cpp ---
    @@ -4940,6 +4946,41 @@ Lng32 ExExeUtilHiveMDaccessTcb::getLengthFromHiveColType(const
char* hiveType)
       if ( !strcmp(hiveType, "timestamp"))
         return 26; //Is this internal or display length? REC_DATETIME;
     
    +  if ( !strcmp(hiveType, "date"))
    +    return 10; //Is this internal or display length? REC_DATETIME;
    +  
    +  if ( !strncmp(hiveType, "varchar",7) )
    +  {
    +    //try to get the length
    +    char maxLen[32];
    +    memset(maxLen, 0, 32);
    +    int i=0,j=0;
    +    short copyit = 0;
    +
    +    if(strlen(hiveType) > 39)  return -1;  
    + 
    +    for(i = 0; i < strlen(hiveType) ; i++)
    --- End diff --
    
    Not sure if the compiler would optimize it to avoid calling strlen everytime.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message