trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #523: TRAFODION [2025] Initialize authoriza...
Date Mon, 06 Jun 2016 14:28:33 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/523#discussion_r65899408
  
    --- Diff: core/sql/cli/Context.cpp ---
    @@ -3850,6 +3856,48 @@ void ContextCli::createMxcmpSession()
       mxcmpSessionInUse_ = TRUE;
     }
     
    +// ----------------------------------------------------------------------------
    +// Method:  updateMxcmpSession
    +//
    +// Updates security attributes in child arkcmp
    +//
    +// Returns: 0 = succeeded; -1 = failed
    +// ----------------------------------------------------------------------------
    +Int32 ContextCli::updateMxcmpSession()
    +{
    +  // If no child arkcmp, just return
    +  if (getArkcmp()->getServer() == NULL)
    --- End diff --
    
    At the time ContextCli is instantiated, the first entry in arkcmpArray_ is created.  So
there should always be entry 0.  The method getArkcmp() returns the 0 entry if none is specified.
 Therefore, getArkcmp() should not be NULL.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message