trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nonstop-qfchen <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #523: TRAFODION [2025] Initialize authoriza...
Date Mon, 06 Jun 2016 16:54:45 GMT
Github user nonstop-qfchen commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/523#discussion_r65926522
  
    --- Diff: core/sql/arkcmp/CmpStatement.cpp ---
    @@ -1254,17 +1255,34 @@ CmpStatement::process(const CmpMessageDatabaseUser &statement)
     {
       NABoolean doDebug = FALSE;
     
    -  NAString message = statement.data();
    +  // The message contains the following:
    --- End diff --
    
    Should we check the length of the message to make sure it covers the various fields checked
here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message