trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nonstop-qfchen <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #523: TRAFODION [2025] Initialize authoriza...
Date Mon, 06 Jun 2016 17:14:32 GMT
Github user nonstop-qfchen commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/523#discussion_r65929614
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommon.cpp ---
    @@ -7764,52 +7734,103 @@ short CmpSeabaseDDL::initSeabaseAuthorization(
         // Add an error if none yet defined in the diags area
         if ( CmpCommon::diags()->getNumber(DgSqlCode::ERROR_) == 0)
           SEABASEDDL_INTERNAL_ERROR("initialize authorization");
    -    cliRC = -1;
    +
    +    return -1;
       }
     
    -  endXnIfStartedHere(cliInterface, xnWasStartedHere, cliRC);
    +  // If DDL transactions are not enabled, commit the transaction so privmgr 
    +  // schema exists in other processes
    +  if (NOT ddlXns)
    +  {
    +    endXnIfStartedHere(cliInterface, xnWasStartedHere, 0);
    +    if (beginXnIfNotInProgress(cliInterface, xnWasStartedHere))
    +    {
    +      SEABASEDDL_INTERNAL_ERROR("initialize authorization");
    +      return -1;
    +    }
    +  }
     
    -  return cliRC;
    +  // change authorization status in compiler contexts
    +  //CmpCommon::context()->setAuthorizationState (1);
    --- End diff --
    
    Should we remove this commented out line?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message