trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #544: [TRAFODION-2044] Support SALT clause ...
Date Mon, 13 Jun 2016 21:15:18 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/544#discussion_r66869592
  
    --- Diff: core/sql/parser/sqlparser.y ---
    @@ -24909,7 +24946,6 @@ create_table_as_token: TOK_AS
     
     /* type pElemDDL */
     table_definition_body : table_element_list
    -                      | like_definition
                           | external_table_definition
     
    --- End diff --
    
    This is intentional. The problem is that including like_definition in table_definition_body
allows things like STORE BY and several other clauses to follow the LIKE option. But the LIKE
code just ignores them all. That is, the original implementation was incomplete. I wanted
to make the unsupported syntax invalid.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message