trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request #545: JIRA TRAFODION-2060 Add support for t...
Date Tue, 14 Jun 2016 22:46:58 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sql/common/BaseTypes.cpp ---
    @@ -412,6 +419,13 @@ short convertTypeToText_basic(char * text,	   // OUTPUT
     	str_sprintf(text, "NUMERIC(%d, %d) UNSIGNED", precision, scale);
    +    case REC_BIN8_UNSIGNED:
    +      if (!precision)
    +        str_sprintf(text, "TINYINT UNSIGNED");
    +      else
    +	str_sprintf(text, "NUMERIC(%d, %d)", precision, scale);
    --- End diff --
    Should this be NUMERIC UNSIGNED?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message