trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #545: JIRA TRAFODION-2060 Add support for t...
Date Tue, 14 Jun 2016 22:54:26 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/545#discussion_r67072771
  
    --- Diff: core/sql/common/NumericType.h ---
    @@ -445,6 +443,99 @@ class SQLBPInt : public NumericType
     
     // ***********************************************************************
     //
    +//  SQLTiny : SQL TINY
    +//
    +// ***********************************************************************
    +class SQLTiny : public NumericType
    +{
    +public:
    +  // ---------------------------------------------------------------------
    +  // Constructor functions
    +  // ---------------------------------------------------------------------
    +  SQLTiny (NABoolean allowNegValues = TRUE, 
    +           NABoolean allowSQLnull = TRUE,
    +           CollHeap * heap =0);
    +  
    +   short getFSDatatype() const
    +    {
    +      if (isUnsigned())
    +	return REC_BIN8_UNSIGNED;
    +      else
    +	return REC_BIN8_SIGNED;
    +    }
    +
    +  NABoolean roundTripConversionToDouble() const { return TRUE; };
    +
    +  virtual Lng32 getMagnitude() const { return isUnsigned() ? 28 : 25; }
    --- End diff --
    
    What's "magnitude"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message