trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #546: TRAFODION [109] Instrument Trafodion ...
Date Wed, 15 Jun 2016 15:43:02 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/546#discussion_r67187426
  
    --- Diff: core/sqf/sql/scripts/sqstart ---
    @@ -220,6 +220,31 @@ function SQCheckOrphanProcesses {
     
     }
     
    +function checkKerberos {
    +
    +   # Check to see if kerberos is enabled in Hadoop
    +   cat /etc/hadoop/conf/core-site.xml | while read a; do
    +     found=`echo $a | grep "hadoop.security.authentication" | wc -l`
    +     if [[ $found -eq 1 ]]; then
    +       read b
    +       enabled=`echo $b | grep kerberos | wc -l`
    --- End diff --
    
    This code seems to assume that kerberos is on the very next line after "hadoop.security.authorization".
Which is probably true but not necessarily. They could be on the same line, for example, or
a comment line could occur between them. That said, without a full-blown XML parsing this
is probably as good as you'll get.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message