trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #545: JIRA TRAFODION-2060 Add support for t...
Date Thu, 16 Jun 2016 17:42:19 GMT
Github user anoopsharma00 commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/545#discussion_r67390668
  
    --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/InterfaceResultSet.java
---
    @@ -503,6 +515,11 @@ static Object getExecute2FetchString(TrafT4Connection conn, TrafT4Desc
desc, byt
     				break;
     			}
     			break;
    +		case SQLTYPECODE_TINYINT:
    +		case SQLTYPECODE_TINYINT_UNSIGNED:
    +                        short sValue1 = (byte) values[noNullValue];
    +			retObj = new Short(sValue1);
    +			break;
    --- End diff --
    
    We dont have full support for tinyint IO from odbc/jdbc interface.
    This code is part of jdbc and will not be reached until that support is in.
    Once that support is in, these paths will be fixed and tested.
    Until then, tinyint will be converted to smallint in the engine.
    
    Based on the review comment, have updated this code to handle unsigned tinyint.
    But it will not be tested and enabled until full jdbc/odbc support has been added.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message