trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #552: JIRA TRAFODION-2072 plus few more
Date Tue, 21 Jun 2016 16:02:12 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/552#discussion_r67898553
  
    --- Diff: core/sql/parser/StmtDDLCreate.cpp ---
    @@ -5007,7 +5020,31 @@ StmtDDLCreateTable_visitTableDefElement(ElemDDLNode * pCreateTableNode,
       StmtDDLCreateTable * pCreateTable =
         pCreateTableNode->castToStmtDDLCreateTable();
     
    -  if (pElement->castToElemDDLConstraint() NEQ NULL)
    +  if (pElement->castToElemDDLLikeCreateTable() NEQ NULL)
    +    {
    +      pCreateTable->likeSourceTableCorrName_ = 
    +        pElement->castToElemDDLLikeCreateTable()
    +        ->getDDLLikeNameAsCorrName();
    +      pCreateTable->likeOptions_ = 
    +        pElement->castToElemDDLLikeCreateTable()
    +        ->getLikeOptions();
    +
    +      if ((NOT pCreateTable->isExternal()) &&
    +          (pElement->castToElemDDLLikeCreateTable()->forExtTable()))
    +        {
    +          *SqlParser_Diags << DgSqlCode(-3242)
    +                           << DgString0("'for' clause can only be specified when
creating an 'external' table.");
    --- End diff --
    
    It looks like the style of SqlciErrors.txt is to put syntax elements in upper case in
error messages, unquoted. So, for example, "FOR clause can only be specified when creating
an external table."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message