trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #552: JIRA TRAFODION-2072 plus few more
Date Tue, 21 Jun 2016 16:07:27 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/552#discussion_r67899548
  
    --- Diff: core/sql/common/NAType.cpp ---
    @@ -670,6 +671,84 @@ short NAType::convertTypeToText(char * text,	   // OUTPUT
     				 displayCaseSpecific);
     }
     
    +short NAType::getMyTypeAsHiveText(NAString * outputStr)  // output
    +{
    +  Lng32		      fs_datatype		= getFSDatatype();
    +
    +  switch (fs_datatype)
    +    {
    +    case REC_MIN_F_CHAR_H ... REC_MAX_F_CHAR_H:
    +      *outputStr = "string";
    +      break;
    +
    +    case REC_MIN_V_CHAR_H ... REC_MAX_V_CHAR_H:
    +      {
    +        SQLVarChar * ct = (SQLVarChar*)this;
    +        if (ct->wasHiveString())
    +          *outputStr = "string";
    --- End diff --
    
    Ah, now I see the point of the "wasHiveString" business. It's to recover the original
Hive data type on a describe.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message