trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #559: [TRAFODION-1988] Better Java exceptio...
Date Mon, 27 Jun 2016 17:30:38 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/559#discussion_r68619686
  
    --- Diff: core/sqf/src/seatrans/tm/hbasetmlib2/src/main/java/org/trafodion/dtm/TmAuditTlog.java
---
    @@ -961,18 +814,14 @@ public static boolean deleteRecord(final long lvTransid) throws
IOException {
           if (LOG.isTraceEnabled()) LOG.trace("deleteRecord start " + lvTransid);
           String transidString = new String(String.valueOf(lvTransid));
           int lv_lockIndex = (int)(lvTransid & tLogHashKey);
    -      try {
    +      //try {
    --- End diff --
    
    Maybe should remove this comment? (since the corresponding catch block was removed)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message