trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #560: JIRA 2086 Support for largeint unsign...
Date Tue, 28 Jun 2016 22:05:55 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/560#discussion_r68852887
  
    --- Diff: core/sql/common/ComSmallDefs.h ---
    @@ -78,7 +78,7 @@ typedef          Int32          ComSInt32;
     #define MAX_HARDWARE_SUPPORTED_SIGNED_NUMERIC_PRECISION 18
     
     //Unsigned NUMERICs upto this range are supported by hardware.
    -#define MAX_HARDWARE_SUPPORTED_UNSIGNED_NUMERIC_PRECISION 9
    +#define MAX_HARDWARE_SUPPORTED_UNSIGNED_NUMERIC_PRECISION 20
    --- End diff --
    
    Elsewhere we used 19 for the precision of LARGEINT UNSIGNED?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message