trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #544: [TRAFODION-2044] Support SALT clause ...
Date Mon, 13 Jun 2016 18:22:52 GMT
GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/544

    [TRAFODION-2044] Support SALT clause on CREATE TABLE LIKE

    Formerly, several clauses (examples: SALT and STORE BY) were allowed on CREATE TABLE LIKE,
but were ignored. So, for example, one could say, "CREATE TABLE t2 LIKE t1 SALT USING 6 PARTITIONS",
but t2 would end up getting the same salting as t1 instead.
    
    With this change, the parser has been changed so that, except for SALT, specifying these
clauses will now result in a syntax error.
    
    For the SALT clause, it is now fully supported with CREATE TABLE LIKE. So, in our example
above, t2 would get 6 partitions, and would be salted on the primary key.
    
    A new regression test, seabase/TEST040, has been added to cover this support. The manuals
have also been updated, and a few unrelated corrections in CREATE TABLE have been made also.
    
    This pull request also updates the expected results for regression test compGeneral/TEST015,
which has been failing for a little while. This change is unrelated to the rest of the changes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion2044

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/544.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #544
    
----
commit 33448ee5a7f19c3a6ae47ced585bbdc265721ed5
Author: Dave Birdsall <dbirdsall@apache.org>
Date:   2016-06-13T18:16:22Z

    [TRAFODION-2044] Support SALT clause on CREATE TABLE LIKE

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message