trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <>
Subject [GitHub] incubator-trafodion pull request #564: [TRAFODION-1676]support better runtim...
Date Fri, 01 Jul 2016 00:13:11 GMT
Github user traflm commented on a diff in the pull request:
    --- Diff: core/sql/cli/Statement.cpp ---
    @@ -2298,6 +2298,10 @@ RETCODE Statement::resolveNames(LateNameInfoList * lnil,
     	      if (retcode != ex_expr::EXPR_OK)
     		  diagsArea << DgSqlCode(-EXE_CONVERT_STRING_ERROR);
    +                  char hexstr[MAX_OFFENDING_SOURCE_DATA_DISPLAY_LEN];
    --- End diff --
    thanks Dave, I will change it. This may core dump the program.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message