trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #574: Fix for [TRAFODION-2091] Lobglobals a...
Date Tue, 05 Jul 2016 14:01:01 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/574#discussion_r69567472
  
    --- Diff: core/sql/src/main/java/org/trafodion/sql/HBulkLoadClient.java ---
    @@ -475,10 +475,12 @@ public boolean release( ) throws IOException {
            writer.close();
            writer = null;
         }
    -    if (fileSys !=null)
    +    // sss This is one place that is unconditionally closing the 
    --- End diff --
    
    Should we remove "sss". It is a minor nit, and I know it is an oversight. Maybe this can
be done in a subsequent checkin?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message