trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #574: Fix for [TRAFODION-2091] Lobglobals a...
Date Tue, 05 Jul 2016 14:03:37 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/574#discussion_r69567976
  
    --- Diff: core/sql/cli/Context.cpp ---
    @@ -298,6 +299,8 @@ ContextCli::ContextCli(CliGlobals *cliGlobals)
     
       seqGen_ = new(exCollHeap()) SequenceValueGenerator(exCollHeap());
     
    +  hdfsHandleList_ = new(exCollHeap()) HashQueue(exCollHeap(), 50); // The hfsHandleList_
represents a list of distict hdfs Handles with unique hdfs port numbers and server names.
Assume not more than 50 hdfsServers could be connected in the Trafodion setup.  These will
get initialized the first time access is made to a particular hdfs server. This list gets
cleaned up when the thread exits. 
    --- End diff --
    
    Can the literal 50 be a constant in a subsequent checkin?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message