trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #577: [TRAFODION-1673] support with clause
Date Thu, 07 Jul 2016 00:25:36 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/577#discussion_r69835003
  
    --- Diff: core/sql/parser/sqlparser.y ---
    @@ -6579,6 +6581,9 @@ table_reference : table_name_and_hint
                   | rel_subquery_and_as_clause
                     { $$ = $1; }
     
    +              | with_clause_list
    --- End diff --
    
    The ANSI SQL standard defines the "with" clause as part of a query_expression, so I would
recommend doing the same here (non_join_query_expression in our case). Also, it would be good
to accept the WITH RECURSIVE syntax and to give an error that this is not yet supported.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message