trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #577: [TRAFODION-1673] support with clause
Date Thu, 07 Jul 2016 00:46:11 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/577#discussion_r69836669
  
    --- Diff: core/sql/parser/sqlparser.y ---
    @@ -7001,6 +7036,46 @@ rel_subquery_and_as_clause : rel_subquery as_clause
                                    $$ = $2;
                                  }
     
    +with_clause_list : with_clause
    +                     {  $$ = $1 ; }
    +
    +                   | with_clause_list ',' correlation_name TOK_AS rel_subquery 
    --- End diff --
    
    Can we do this in a way that doesn't have two different rules for the first and the subsequent
parts of the WITH clause? See comment above for how the ANSI standard handles the WITH clause.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message