trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #577: [TRAFODION-1673] support with clause
Date Thu, 07 Jul 2016 15:49:39 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/577#discussion_r69932659
  
    --- Diff: core/sql/parser/sqlparser.y ---
    @@ -14684,6 +14759,11 @@ optional_limit_spec : TOK_LIMIT NUMERIC_LITERAL_EXACT_NO_SCALE
     
     dml_statement : dml_query { $$ = $1; }
     
    +               | with_clause_list dml_query
    --- End diff --
    
    That is the number of conflicts encountered by the bison parser when it processes file
core/sql/parser/sqlparser.y. Here is how I get this information:
    
    ```
    touch core/sql/parser/sqlparser.y
    cd core/sql/nskgmake
    gmake -j 4 -ks linuxdebug
    ```
    
    Here is the current output:
    
    ```
    ../parser/sqlparser.y: warning: 73 shift/reduce conflicts [-Wconflicts-sr]
    ../parser/sqlparser.y: warning: 12 reduce/reduce conflicts [-Wconflicts-rr]
    ```
    
    If you get a different (higher) number, then we would have to investigate whether there
are any potential problems with the new syntax.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message