trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #589: [TRAFODION-2097] :Adding retry logic ...
Date Mon, 11 Jul 2016 20:17:26 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/589#discussion_r70328459
  
    --- Diff: core/sql/executor/ExHdfsScan.cpp ---
    @@ -585,6 +585,17 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
                        openType //
                        );
                     
    +                if ((retcode < 0) &&
    +                    ((errno == ENOENT) || (errno == EAGAIN)))
    --- End diff --
    
    errno is a global variable that might be set by any system library call. It is dangerous
to rely on it except right after the system call where it is set. But in this code, it looks
like the library call is buried inside ExpLOBInterfaceSelectCursor. It would be safer if the
latter function saved errno after whatever system library call it calls, and returns that
as an "out" parameter, which this code could then check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message