trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #589: [TRAFODION-2097] :Adding retry logic ...
Date Mon, 11 Jul 2016 20:25:58 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/589#discussion_r70329836
  
    --- Diff: core/sql/exp/ExpLOBaccess.cpp ---
    @@ -552,8 +552,9 @@ Ex_Lob_Error ExLob::statSourceFile(char *srcfile, Int64 &sourceEOF)
        if (srcType == HDFS_FILE)
          {
            hdfsFile sourceFile = hdfsOpenFile(fs_,srcfile,O_RDONLY,0,0,0);   
    --- End diff --
    
    No not this. There are 3 other places in this file where it's set. But still experimenting
with this fix. If this works, a new error number will be generated  right after the call to
hdfsOpenFile . If errno is EAGAIN or ENOENT, the new error message will be  returned and we
will retry based on that error at the higher layer.  But  the suggestion to return errno and
perhaps also the filename as an output param may be a good one too. Will consider it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message