trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request #590: JIRA TRAFODION-2099 Add support for b...
Date Mon, 11 Jul 2016 23:53:26 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sql/optimizer/UdfDllInteraction.cpp ---
    @@ -1214,6 +1214,29 @@ NABoolean TMUDFInternalSetup::setTypeInfoFromNAType(
               switch (length)
                   // SMALLINT, INT, LARGEINT, NUMERIC, signed and unsigned
    +            case 1:
    +              if (CmpCommon::getDefault(TRAF_TINYINT_SPJ_SUPPORT) == DF_ON)
    --- End diff --
    Did you mean DF_OFF? Seems odd that if TRAF_TINYINT_SPJ_SUPPORT is 'ON' then we *wouldn't*
support tinyint.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message