trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #590: JIRA TRAFODION-2099 Add support for b...
Date Tue, 12 Jul 2016 15:14:36 GMT
Github user anoopsharma00 commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/590#discussion_r70459292
  
    --- Diff: core/sql/exp/exp_attrs.cpp ---
    @@ -278,6 +278,8 @@ switch (datatype)
       case REC_INT_FRACTION: return extFormat? (char *)"INTERVAL FRACTION":(char *)"REC_INT_FRACTION";
       case REC_BLOB: return extFormat? (char *)"BLOB":(char *)"REC_BLOB";
       case REC_CLOB: return extFormat? (char *)"CLOB":(char *)"REC_CLOB";
    +  case REC_BOOLEAN: return extFormat ? (char *)"BOOLEAN" : (char *)"BOOLEAN";
    --- End diff --
    
    The second string should be "REC_BOOLEAN" instead of "BOOLEAN". Will fix
    that in a subsequent checkin.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message