trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #590: JIRA TRAFODION-2099 Add support for b...
Date Tue, 12 Jul 2016 15:17:12 GMT
Github user anoopsharma00 commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/590#discussion_r70459837
  
    --- Diff: core/sql/optimizer/UdfDllInteraction.cpp ---
    @@ -1214,6 +1214,29 @@ NABoolean TMUDFInternalSetup::setTypeInfoFromNAType(
               switch (length)
                 {
                   // SMALLINT, INT, LARGEINT, NUMERIC, signed and unsigned
    +            case 1:
    +              if (CmpCommon::getDefault(TRAF_TINYINT_SPJ_SUPPORT) == DF_ON)
    --- End diff --
    
    Some support still need to be added to SPJ/T2 driver path for tinyint.
    If this cqd is turned on, it continues to the path of processing tinyint.
    Since tinyint support is not yet in for spj/t2, an error is currently returned. 
    This is not an externalized cqd.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message