trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #577: Trafodion 1673 with clause
Date Wed, 06 Jul 2016 15:26:52 GMT
GitHub user traflm opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/577

    Trafodion 1673 with clause

    initial support new SQL syntax 'WITH', which required in many use cases, for example,
in 35 TPCDS queries.
    This change will transform the WITH definition into sub query, so can be used in later
compile phases.
    As tested, in 35 TPCDS queries that contains WITH, this change pass 19 of them , others
due to other syntax gap, like rollup. The passed TPCDS queries include:
     q1
    q2
    q4
    q11
    q23
    q24
    q30
    q31
    q33
    q51
    q54
    q56
    q58
    q59
    q60
    q64
    q81
    q83
    q97
    
    Since still not widely tested, this syntax is still protected by MODE_SPECIAL_4 CQD.
    
    Please help to code review it. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/traflm/incubator-trafodion TRAFODION-1673-with-clause

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/577.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #577
    
----
commit 947797de2f0d7db1c346b19a7b50b4cb59c35bb0
Author: Liu Ming <ovis_poly@sina.com>
Date:   2016-07-06T14:36:10Z

    initial support of WITH

commit 79b421ffdce28f7d151605bd4f1e64c308175b20
Author: Liu Ming <ovis_poly@sina.com>
Date:   2016-07-06T15:19:22Z

    add regression test for WITH support jira

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message